fix(ECS): honor query argument bindings in DeepRAG and Batch Transform - #1125
Merged
Merged
Conversation
gauravsingh-rajput
changed the title
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Batch Transform’s new binding behavior lacks equivalent regression coverage.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Binds DeepRAG and Batch Transform queries to the configured agent input.
Changes:
- Adds query argument bindings to both internal tools.
- Adds a DeepRAG regression test preserving the exact input value.
| File | Description |
|---|---|
deeprag_tool.py |
Adds configured query binding. |
batch_transform_tool.py |
Adds configured query binding. |
test_deeprag_tool.py |
Tests DeepRAG input preservation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
gauravsingh-rajput
force-pushed
the
fix/deeprag-static-arg
branch
2 times, most recently
from
September 30, 2026 21:51
1e91579 to
cfc936d
Compare
CalebMartinUiPath
approved these changes
Sep 30, 2026
gcuip
approved these changes
Oct 1, 2026
gauravsingh-rajput
force-pushed
the
fix/deeprag-static-arg
branch
from
October 1, 2026 17:58
cfc936d to
55f4e60
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix DeepRAG and Batch Transform ignoring the selected query argument. Bind the query to the selected agent input so its value is passed unchanged.
Validation: 20 focused tests passed, along with full-repo type, lint, formatting, and HTTP client checks. Regression coverage verifies that both tools preserve the selected input value.