Skip to content

[hotfix] add defaults for missing symbols #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cvanelteren wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −3
Open

[hotfix] add defaults for missing symbols #752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions ultraplot/constructor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,9 +227,13 @@ def _build_formatter_registry() -> dict[str, object]:
if hasattr(mdates, "ConciseDateFormatter"):
registry["concise"] = mdates.ConciseDateFormatter
if _version_cartopy >= "0.18":
registry["dms"] = partial(pticker.DegreeFormatter, dms=True)
registry["dmslon"] = partial(pticker.LongitudeFormatter, dms=True)
registry["dmslat"] = partial(pticker.LatitudeFormatter, dms=True)
# Cartopy defaults to U+2032/U+2033 prime glyphs for minutes/seconds.
# TeX Gyre Heros, UltraPlot's default sans-serif font, does not contain
# those glyphs, so use ASCII symbols for the built-in DMS presets.
dms_kwargs = {"dms": True, "minute_symbol": "'", "second_symbol": '"'}
registry["dms"] = partial(pticker.DegreeFormatter, **dms_kwargs)
registry["dmslon"] = partial(pticker.LongitudeFormatter, **dms_kwargs)
registry["dmslat"] = partial(pticker.LatitudeFormatter, **dms_kwargs)
return registry


Expand Down
9 changes: 9 additions & 0 deletions ultraplot/tests/test_geographic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,15 @@ def test_lon0_shifts():
uplt.close(fig)


def test_dms_formatter_symbols_are_default_font_safe():
formatter = uplt.Formatter("dmslon")
label = formatter(1 + 1 / 60 + 1 / 3600)
assert "\N{PRIME}" not in label
assert "\N{DOUBLE PRIME}" not in label
assert "'" in label
assert '"' in label


@pytest.mark.parametrize(
"layout, expectations",
[
Expand Down
Loading