Conversation
The repository accumulated ~13 tests disabled via unconditional
t.Skip("... requires ...") calls -- several dormant since 2024. The
pattern is invisible to a normal 'go test' run (skipped tests are
reported per package but rarely reviewed in aggregate), so drift
compounds silently.
Add a skip-audit Make target that:
- Lists every t.Skip / b.Skip in the test tree.
- Categorizes each into one of three buckets using message-content
heuristics:
Short-mode skips - correct behavior under 'go test -short'
Conditional data - legitimate skips when seed data is absent
Disabled tests - unconditional skips that need review
- Prints a summary line with totals so a periodic review can see if
the "disabled" count is trending up.
- Is informational only (never fails the build) so it can be run
ad-hoc without wedging CI.
Ownership guidance in the target's godoc: for each entry in the
"disabled" section, a maintainer should either re-enable the test,
delete it as no longer relevant, or file a tracking issue and link
the issue in the skip message.
Running today:
Total: 27 skip calls | disabled tests needing review: 13
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repository accumulated ~13 tests disabled via unconditional
t.Skip("... requires ...") calls -- several dormant since 2024. The
pattern is invisible to a normal 'go test' run (skipped tests are
reported per package but rarely reviewed in aggregate), so drift
compounds silently.
Add a skip-audit Make target that:
heuristics:
Short-mode skips - correct behavior under 'go test -short'
Conditional data - legitimate skips when seed data is absent
Disabled tests - unconditional skips that need review
the "disabled" count is trending up.
ad-hoc without wedging CI.
Ownership guidance in the target's godoc: for each entry in the
"disabled" section, a maintainer should either re-enable the test,
delete it as no longer relevant, or file a tracking issue and link
the issue in the skip message.
Running today:
Total: 27 skip calls | disabled tests needing review: 13