Conversation
The coverage-check target enforced a 95% threshold the codebase has never met -- measured per-package coverage is 74.1% -- so the gate always failed and was effectively ignored. Lower the threshold to a COVERAGE_MIN floor of 70 (overridable), just below the current 74.1%, documented as a floor to raise rather than lower. On failure the message now points at coverage-report and the new coverage-gaps helper instead of only exiting. coverage-gaps lists the 20 least-covered functions so contributors can see where to invest in tests. Coverage is measured per-package -- the same coverage.out that make test produces -- so packages with no unit tests (the generated mocks and OpenAPI stubs) are absent from the profile rather than dragging the number down; no separate exclusion is needed. Also gitignore the coverage.txt and coverage.html artifacts the coverage targets produce.
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The coverage-check target enforced a 95% threshold the codebase has
never met -- measured per-package coverage is 74.1% -- so the gate
always failed and was effectively ignored.
Lower the threshold to a COVERAGE_MIN floor of 70 (overridable), just
below the current 74.1%, documented as a floor to raise rather than
lower. On failure the message now points at coverage-report and the new
coverage-gaps helper instead of only exiting.
coverage-gaps lists the 20 least-covered functions so contributors can
see where to invest in tests. Coverage is measured per-package -- the
same coverage.out that make test produces -- so packages with no unit
tests (the generated mocks and OpenAPI stubs) are absent from the
profile rather than dragging the number down; no separate exclusion is
needed.
Also gitignore the coverage.txt and coverage.html artifacts the coverage
targets produce.