Skip to content

chore: make coverage-check a realistic gate and add coverage-gaps helper - #367

Open
mrofreP wants to merge 1 commit into
UndernetIRC:masterfrom
mrofreP:chore/fix-coverage-check-threshold
Open

mrofreP wants to merge 1 commit into
UndernetIRC:masterfrom
mrofreP:chore/fix-coverage-check-threshold

Conversation

@mrofreP

@mrofreP mrofreP commented Jul 18, 2026

Copy link
Copy Markdown

The coverage-check target enforced a 95% threshold the codebase has
never met -- measured per-package coverage is 74.1% -- so the gate
always failed and was effectively ignored.

Lower the threshold to a COVERAGE_MIN floor of 70 (overridable), just
below the current 74.1%, documented as a floor to raise rather than
lower. On failure the message now points at coverage-report and the new
coverage-gaps helper instead of only exiting.

coverage-gaps lists the 20 least-covered functions so contributors can
see where to invest in tests. Coverage is measured per-package -- the
same coverage.out that make test produces -- so packages with no unit
tests (the generated mocks and OpenAPI stubs) are absent from the
profile rather than dragging the number down; no separate exclusion is
needed.

Also gitignore the coverage.txt and coverage.html artifacts the coverage
targets produce.

The coverage-check target enforced a 95% threshold the codebase has
never met -- measured per-package coverage is 74.1% -- so the gate
always failed and was effectively ignored.

Lower the threshold to a COVERAGE_MIN floor of 70 (overridable), just
below the current 74.1%, documented as a floor to raise rather than
lower. On failure the message now points at coverage-report and the new
coverage-gaps helper instead of only exiting.

coverage-gaps lists the 20 least-covered functions so contributors can
see where to invest in tests. Coverage is measured per-package -- the
same coverage.out that make test produces -- so packages with no unit
tests (the generated mocks and OpenAPI stubs) are absent from the
profile rather than dragging the number down; no separate exclusion is
needed.

Also gitignore the coverage.txt and coverage.html artifacts the coverage
targets produce.
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant