Conversation
ProcessMail built the envelope-from as "<local>+<random>@<domain>" with the random drawn into a signed int32, so roughly half of all sends emitted "local+-1234567@domain" -- a "-" where a digit is expected. Read the random into a uint32 so the suffix is always a well-formed non-negative integer. Also replace the stale "TODO: temporary fix to see if this corrects the sending issue" comment with an accurate description of the envelope-from: the domain comes from SMTPFromEmail to align with the From header (a mismatch is a classic SPF/DMARC failure); the "+<random>" suffix predates that alignment and has no recorded purpose (it is not VERP and there is no bounce handling); and the domain falls back to "localhost" when SMTPFromEmail is unset or malformed.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProcessMail built the envelope-from as "+@" with
the random drawn into a signed int32, so roughly half of all sends
emitted "local+-1234567@domain" -- a "-" where a digit is expected. Read
the random into a uint32 so the suffix is always a well-formed
non-negative integer.
Also replace the stale "TODO: temporary fix to see if this corrects the
sending issue" comment with an accurate description of the envelope-from:
the domain comes from SMTPFromEmail to align with the From header (a
mismatch is a classic SPF/DMARC failure); the "+" suffix predates
that alignment and has no recorded purpose (it is not VERP and there is
no bounce handling); and the domain falls back to "localhost" when
SMTPFromEmail is unset or malformed.