Conversation
RequestManagerChange logs the confirmation token as confirmationToken[:8]+"...". On master, GenerateSecureToken swallows a crypto/rand failure and returns "", so confirmationToken can be empty and ""[:8] panics -- a live path, however rare. Guard it with confirmationToken[:min(len(confirmationToken), 8)], matching the guard applied to the user-supplied token in ConfirmManagerChange. The guard is kept even though it is not the root fix: once GenerateSecureToken propagates its error (companion PR, which should merge first), the handler returns 500 before this line and the token is guaranteed non-empty. The guard then costs nothing and future-proofs the log line against a change in the token source. Caveat left as-is: the "..." suffix is unconditional, so an empty token logs just "..." (harmless -- it leaks nothing). Collapsing all six copies of this masking expression into a shared helper is the right cleanup but is out of scope here.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RequestManagerChange logs the confirmation token as
confirmationToken[:8]+"...". On master, GenerateSecureToken swallows a
crypto/rand failure and returns "", so confirmationToken can be empty
and ""[:8] panics -- a live path, however rare. Guard it with
confirmationToken[:min(len(confirmationToken), 8)], matching the guard
applied to the user-supplied token in ConfirmManagerChange.
The guard is kept even though it is not the root fix: once
GenerateSecureToken propagates its error (companion PR, which should
merge first), the handler returns 500 before this line and the token is
guaranteed non-empty. The guard then costs nothing and future-proofs the
log line against a change in the token source.
Caveat left as-is: the "..." suffix is unconditional, so an empty token
logs just "..." (harmless -- it leaks nothing). Collapsing all six
copies of this masking expression into a shared helper is the right
cleanup but is out of scope here.