Conversation
The block at cmd/cservice-api/main.go:398-416 created an
InstrumentedScheduler and immediately discarded it via
_ = instrumentedScheduler with an inline comment saying "Prevent
unused variable error". The preceding log line ("Instrumented cron
scheduler created (integration pending)") and the block comment
("We would need to modify the cron.Service to accept an
instrumented scheduler") both acknowledged the block does nothing
useful.
Users were getting the non-instrumented scheduler either way (via
cronService.SetupPasswordResetCleanup a few lines below), so the
block was a misleading no-op that hinted at capabilities the service
does not actually provide.
Delete the block. If genuine instrumentation integration is desired
later, it should be added by wiring an instrumented scheduler into
cron.Service.SetupPasswordResetCleanup, not by re-adding dead
scaffolding here.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The block at cmd/cservice-api/main.go:398-416 created an
InstrumentedScheduler and immediately discarded it via
_ = instrumentedScheduler with an inline comment saying "Prevent
unused variable error". The preceding log line ("Instrumented cron
scheduler created (integration pending)") and the block comment
("We would need to modify the cron.Service to accept an
instrumented scheduler") both acknowledged the block does nothing
useful.
Users were getting the non-instrumented scheduler either way (via
cronService.SetupPasswordResetCleanup a few lines below), so the
block was a misleading no-op that hinted at capabilities the service
does not actually provide.
Delete the block. If genuine instrumentation integration is desired
later, it should be added by wiring an instrumented scheduler into
cron.Service.SetupPasswordResetCleanup, not by re-adding dead
scaffolding here.