Conversation
internal/cron/cron_test.go:313 had TestRealPasswordResetCleanup
disabled with t.Skip("Integration test - requires database setup").
The skip was a false negative — the test only exercises the
scheduler's job-registration path (AddPasswordResetCleanupJob +
GetEntries) and never triggers the cron entry, so the nil Querier
held by the reset.TokenManager is never dereferenced. No database is
actually required.
The reset.NewTokenManager and reset.NewCleanupService constructors
are both nil-safe for the code paths this test exercises, so the
existing body works as-is once the unconditional skip is removed.
Refresh the doc comment to explain the scope (registration only,
not execution) so a future reader does not re-add the skip.
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internal/cron/cron_test.go:313 had TestRealPasswordResetCleanup
disabled with t.Skip("Integration test - requires database setup").
The skip was a false negative — the test only exercises the
scheduler's job-registration path (AddPasswordResetCleanupJob +
GetEntries) and never triggers the cron entry, so the nil Querier
held by the reset.TokenManager is never dereferenced. No database is
actually required.
The reset.NewTokenManager and reset.NewCleanupService constructors
are both nil-safe for the code paths this test exercises, so the
existing body works as-is once the unconditional skip is removed.
Refresh the doc comment to explain the scope (registration only,
not execution) so a future reader does not re-add the skip.