Conversation
msg_tag_format_s2s() dropped every client-only (+) tag, so a TAGMSG relayed to another server arrived as a bare TM and a PRIVMSG lost its client tags at the first hop. Only clients on the sending server ever saw them; every existing tag test observed two clients on one server. Forward client-only tags that pass this server's CLIENTTAGDENY. Tags from a local client were already filtered at parse time, and the receiving server filters again on delivery, so the deny list applies on both edges. Add tests: a leaf-side observer receives the tag on channel PRIVMSG, TAGMSG and private PRIVMSG while a denied tag on the same line is stripped, and the allowed tag is present on the P10 line leaving the hub.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
msg_tag_format_s2s()dropped every client-only (+) tag before it even consulted CLIENTTAGDENY, so client tags never crossed a server link. A TAGMSG relayed to another server arrived as a bareTM #chan, and a PRIVMSG lost its client tags at the first hop. Only clients on the sending server ever saw them.This has been the behaviour since the original message-tags commit (a060b5d). It went unnoticed because every tag test in the suite observed two clients on the same server; the only leaf-side assertions were for
@time.Fix
Forward client-only tags that pass this server's CLIENTTAGDENY. Tags from a local client were already filtered at parse time, and the receiving server filters again on delivery, so the deny list still applies on both edges. Only
msg_tag.cand its header comment change.Tests
New
tests/pr_msgtags_compat/test_s2s_client_tags.pyon the hub + leaf topology (the docker configs allow exactly+example.com/foo):@time=, with the denied tag absent.Both tests fail on the unfixed formatter (tag missing on the leaf and on the wire) and pass with the fix.