Add support for template 3.33 - #1590
Merged
Merged
Conversation
Contributor
Author
|
Labels grib2 and iosp: grib could be added. |
Member
|
Thank you for your contribution! If you would not mind, could you let us know when a sample message would be available? |
Contributor
Author
|
Yes, I expect end of this year. I had hoped to do something similar to #1574 for this once the index can be generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Add support for grib files using grid definition template 3.33 (https://library.wmo.int/viewer/35625/download?file=WMO-306-v-I-2-2025_en.pdf&type=pdf&navigator=1 page 40.
GDS template 3.33 is the same as 3.30 except 4 additional values (nux, ncx, nuy and ncy).
I know of no public grib files that use 3.33 yet, so testing was done internally - and as I understand it, these 4 values are only used to be able to place the grib file in a larger context (so not used .
But even if those values are not used, parsing still fails with "Unsupported GDS type = 33" - therefore this PR.
PR Checklist
until ready for review