Repository navigation
Add zscoreFS function signature with inputs and outputs - #128
Conversation
Updated parameter 'kind' from 'optional' to 'ordered' for multiple entries and changed type from 'numeric' to 'double'. Also fixed the function signatures errors from zscore
BoschiGiacomo
left a comment
There was a problem hiding this comment.
Hi @matteozanettii, thanks for your submission. There is only one problem with autocompletions that are shown twice, in the following comments you can find a quick fix and explanation.
As soon as it's fixed we can merge your work, thanks.
Removed redundant array structure for type definitions in function signatures.
|
Hi @BoschiGiacomo , thanks for the review! There are all the changes I made: Resolved the issue of duplicated dropdown choices across all functions (including the existing getTickers, getYahoo, and getFundamentals) by merging the "char" and "string" types with their "choices" into a single, unified block., Then fixed the syntax errors in topPanelMode and bottomPanelMode by removing the unsupported textual descriptions from the "type" arrays and moving them into the "purpose" fields; However, compared to what we discussed together, I preserved the original logic of this exact JSON file instead of the other fuctionsignatures files there is the check from the validator:
|
BoschiGiacomo
left a comment
There was a problem hiding this comment.
Hi Matteo, thanks for looking into the other signatures of the file as well. There is a problem introduced by your latest changes: flattening the type arrays changes their meaning from OR to AND; I have detailed it in the comment below.
From the MathWorks documentation:
To match any of multiple classes or attributes, use a list of lists of JSON strings. For the inner lists, MATLAB uses a logical AND of the values.
The same page uses "type":[["char"],["string"]] for an argument that accepts either class.
Once this is fixed, we can merge. Thanks.
|
Hi @BoschiGiacomo , thanks a lot for the explanation and for taking a detailed look at the whole file! |
BoschiGiacomo
left a comment
There was a problem hiding this comment.
Looks good to me. Thank you for your contribution, @matteozanettii!
I pushed a small fix removing 'modmadp' from the scale choices, since it's a placeholder and not a valid value.

Proposed changes
This PR adds the configuration for the zscoreFS function to the functionSignatures.json file.
Details of changes
Mapped inputs: X, loc, scale, and dim.
Choices: Added dropdown autocomplete suggestions for the optional arguments loc ('median', 'mean') and scale ('mad', 'Qn', 'Sn', 'std', 'modmadp').
Mapped outputs: Z, mu, and sigma.
The JSON structure matches the logic of the existing functions in the file, allowing the editor to correctly display parameter suggestions and descriptions while typing.
Types of changes