Fix display of static images without CORS headers - #1841
Merged
Conversation
|
@github-actions[bot] is attempting to deploy a commit to the Universal Viewer Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
kirschbombe
approved these changes
Aug 18, 2026
kirschbombe
left a comment
kirschbombe
left a comment
There was a problem hiding this comment.
I tested locally and this appears to fix the CORS issue with images where this is no image service.
demiankatz
approved these changes
Aug 18, 2026
demiankatz
left a comment
demiankatz
left a comment
Contributor
There was a problem hiding this comment.
Looks straightforward to me. Thanks, @jamesmisson and @kirschbombe!
Contributor
Author
|
Thank you both - I'll merge. |
jamesmisson
merged commit Aug 19, 2026
7853437
into
UniversalViewer:release-4.4.3
4 of 5 checks passed
Saira-A
pushed a commit
to Saira-A/universalviewer
that referenced
this pull request
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the update to OSD 6, UV defaults to using WebGL as the drawer for images. For WebGL to work,
crossOriginPolicyin the OSD viewer options must beAnonymous. But this means that static images without CORS headers don't get loaded.So this PR keeps the
Anonymouspolicy as the default, while specifyingfalsefor images that don't have an image service attached to them (using the existing branches for such images). In such cases, OSD 6 will fallback to usingcanvasas the drawer (this is what happens when thedraweroption is set toauto).Manifests for testing: