Repository navigation
Feat/swims honeypot - #293
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
yrska
requested changes
Oct 3, 2026
yrska
left a comment
yrska
left a comment
Collaborator
There was a problem hiding this comment.
Found the issue!
Syntax error The merge left an extra closing brace in src/collections/swims.ts, right after the beforeChange array, line 48
],
}, // <- delete this line
},
fields: [2. Still open from the last review:
- Make the honeypot a virtual field (
virtual: true,admin: { hidden: true }) so it isn't stored. Then the migration can be deleted entirely. - Throw
new APIError('Submission rejected', 400)instead of a plainError, which returns a 500. - Replace
(values as any).honeypotwithvalues.honeypot. - The linter is asking for
@ts-expect-errorinstead of@ts-ignorein the test.
3. If you do keep the column: typically pnpm payload migrate:create also creates a .json file, can you check if this was missed in the commit? This will also be required for the migration once it is in.
yrska
reviewed
Oct 7, 2026
yrska
left a comment
yrska
left a comment
Collaborator
There was a problem hiding this comment.
All sorted, thanks for working through these ✅
- Syntax error fixed, checks green.
- Honeypot is now virtual and hidden, so no migration is needed.
APIError(400), noas any,@ts-expect-errorin the tests.
yrska
approved these changes
Oct 7, 2026
|
🚀 Preview deployment is live: Preview Link |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #<issue_number>
🌟 Context
Creating a honeypot to stop bot spam
📝 Description
📋 Notes