Repository navigation
fix/past-member-profile-access - #106
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Past members locked out of their profile
MemberRoute only allowed member and admin, so a legacy user hitting /profile was silently redirected home while the header still showed them a Profile link. That’s what made the profile picture unreachable. The backend was never the problem — /users/me and /images/profile/me only check authentication, no role check. Replaced it with AccountRoute, which allows anyone who isn’t a guest, since profile data belongs to the account rather than the membership. MemberRoute is deleted as it’s now unused. Signed-out visitors are still redirected, so the route isn’t open to everyone.
Renewal page layout
The title was rendering smaller than the paragraph under it — it was an unstyled h2. Now an h1 at 48px (34px mobile), matching the signup hero. Added dividers and spacing between the details and payment sections, moved the styles into style/renew.css, and the two-column grid now collapses to one column under 640px where the fields were cramped. Checked at desktop and 390px.