Repository navigation
Fix/image leak - #118
Open
vincenttao04 wants to merge 3 commits into
Open
Fix/image leak#118vincenttao04 wants to merge 3 commits into
vincenttao04 wants to merge 3 commits into
Conversation
vincenttao04
marked this pull request as ready for review
October 21, 2026 14:33
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sponsor images were never deleted when a sponsor was deleted, leaving orphaned files in S3 and Mongo. This PR fixes that leak and removes some duplicated code.
Changes
deleteSponsorcleans up the sponsor's image (S3 object and Mongo record) after confirming the sponsor exists, then deletes the sponsor last, so a cleanup failure leaves everything retryable.deleteImagesByTaghelper inserver/src/util/imageCleanup.ts.deleteExecto use the shared helper. No behaviour change, theexec-image:tag guard is kept.Notes