Skip to content

fix/event-rsvp-membership - #202

Merged
joengy merged 7 commits into
mainfrom
fix/event-rsvp-membership
Oct 11, 2026
Merged

joengy merged 7 commits into
mainfrom
fix/event-rsvp-membership

Conversation

@Robin-deng617

@Robin-deng617 Robin-deng617 commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Only allows user that are signed in to rsvp for events. Removes excess fields in the event rsvp form.

Type of change

  • Feature
  • Bug fix
  • Chore / config
  • Hotfix

Checklist

  • My branch follows the naming convention (feature/, fix/, chore/, hotfix/)
  • My commit messages follow the conventional commits format
  • CI checks pass

Linked Issues

Closes #
Addresses #
Related to #

@joengy joengy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work with the PR Robin, I left some comments which should be fast to implement

Comment thread cms/src/app/event-registration/route.ts
Comment thread cms/src/app/event-registration/route.ts
Comment thread cms/src/app/event-registration/route.ts Outdated
@vercel

vercel Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
ssa Ready Ready Preview Oct 10, 2026 10:37am UTC

henryhlly
henryhlly previously approved these changes Oct 6, 2026

@henryhlly henryhlly left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@henryhlly
henryhlly requested a review from joengy October 6, 2026 22:56

@joengy joengy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your changes Robin, everything LGTM

joengy
joengy previously approved these changes Oct 8, 2026

@joengy joengy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Robin-deng617
Robin-deng617 dismissed stale reviews from joengy and henryhlly via b24ec22 October 10, 2026 10:28
@joengy
joengy merged commit 4ff75c1 into main Oct 11, 2026
5 checks passed

This branch was successfully deployed

1 active deployment
Preview — b24ec220 Deployed Oct 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants