Repository navigation
Add automated SQL Assignment 2 marking - #481
Merged
Merged
Conversation
|
Thanks for your contribution! 🎉 Please remember to tag or request a review from the DSI team. Give us up to 72 hours to review your pull request. We appreciate your patience and efforts. |
danielrazavi
requested review from
khsergvl and
mrpotatocode
and removed request for
mrpotatocode
October 9, 2026 20:00
Jiazhou-Bi
approved these changes
Oct 13, 2026
Jiazhou-Bi
left a comment
Jiazhou-Bi
left a comment
Collaborator
There was a problem hiding this comment.
Not sure about the overall picture of this code, but I could see the logic of comparing the result with expected rows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing Assignment 2 runner shows query output but does not check whether answers are correct. This PR adds correctness checks for all 12 SQL questions and posts feedback on students' pull requests, including after new commits. ERDs, written responses, and final grades still require instructor marking.
Instructor solutions stay in the private staff repo. This PR also reminds students to enable GitHub Actions in their forks.
Tested on GitHub: the private suite passed 21 tests and 25 subtests. A fork submission received the expected feedback for correct and wrong answers, then automatically ran again after an answer was fixed.
References: