Authorize from the mirror unconditionally; alert on a stale reconciler - #2031
Merged
Merged
Conversation
Contributor
Cloudflare previewTorn down — the PR is closed. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | e871001 | Sep 16 2026, 08:51 PM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | e871001 | Commit Preview URL Branch Preview URL |
Sep 16 2026, 08:49 PM |
RhysSullivan
force-pushed
the
mirror-readiness-removal
branch
from
September 16, 2026 20:48
8a3d2d9 to
e871001
Compare
RhysSullivan
marked this pull request as ready for review
September 16, 2026 20:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the member-directory stack (#2003 through #2026).
The per-request
MirrorReadinesscheck and its live WorkOS fallback are removed fromauthorizeOrganization. Every membership authorization now reads the mirror unconditionally. The backfill is complete and permanent, and an organization that predates the mirror is still covered by the existing on-demand scan.A stalled reconciler is an operational alert instead of a per-request fallback. After each cron run that does not end drained, the runner reads the
drained_atheartbeat and, if it is older than the ten-minute lag budget, logsworkos_events: reconciler staleand reports aWorkOsReconcilerStaleerror to Sentry.MirrorReadinessservice and removes it from every layer it was threaded through.scripts/ensure-workos-mirror-ready.ts) is unchanged and still refuses to ship while the mirror is unready.drained_atheartbeat is still written by every reconciler run.mirror.readyspan attributes and the fallback recipe from the prod-telemetry skill, adds the heartbeat and alert recipes.mcp-workos-blip-session-survivale2e scenario for the new contract: a WorkOS outage is invisible to a live session (the request never asks WorkOS), and a membership revoked through the product fails closed on the member's next request and condemns their session.Expected effect: about 13 ms off every authorization, which was measured at 40 ms median after the cutover.
Verified: repo typecheck, lint, and format check pass; the full cloud vitest suite passes; the
org-delete,mcp-session-cold-init, andmcp-workos-blip-session-survivalcloud e2e scenarios pass locally.