fix(oauth): require exact explicit DCR redirect match - #2032
Open
SwedishChef1 wants to merge 1 commit into
Open
SwedishChef1 wants to merge 1 commit into
SwedishChef1 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
redirectUrias authoritativeWhy
A persisted DCR client from before
origin_redirect_uriwas recorded currently matches every callback. A host moving from an ephemeral callback to an explicit stable callback can therefore reuse a client registered for the old URL, causing strict authorization servers to reject the authorization request. Deleting that client is unsafe because existing connections may still use it for refresh.Verification
main: the legacy client is reused despite an explicit callbackbun run test -- src/oauth-register-dynamic.test.ts: 17 passedmcp-oauth-reconnect-origin-driftE2E: passedbun run format:check: passedbun run lint: passedbun run typecheck: 45/45 packages passedThe monorepo-wide concurrent
bun run testexceeded unrelated timing budgets in the 10,000-tool MCP test, stdio daemon startup, and local data-dir ownership test. Each reported failing suite/test passed when rerun in isolation; the full SDK suite also passed.