Move product access rules out of the SDK - #2034
Draft
RhysSullivan wants to merge 1 commit into
Draft
RhysSullivan wants to merge 1 commit into
RhysSullivan wants to merge 1 commit into
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | c676e56 | Commit Preview URL Branch Preview URL |
Sep 17 2026, 05:01 AM |
Contributor
Cloudflare preview
Sign-in is Cloudflare Access (one-time PIN to an allowed email). The preview has its own database and encryption key; it is destroyed when this PR closes. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/product-access
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | c676e56 | Sep 17 2026, 05:04 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move personal/organization access rules into
@executor-js/product-access. Both SDK APIs now requireaccess: ExecutorAccess; core enforces the supplied visibility, settings, storage, and tool-policy decisions while retaining tenant and subject isolation. All hosts, callers, examples, and test helpers use the new boundary, with no legacy fallback or stored-data migration.Remove
orgWritesandplatformView. Recheck tool policy and retained connection/tool rows after approval, and enforce narrowed access and read-only storage on plugin blobs. Include package build/release wiring and migration guidance.Verification
bun run format:checkandbun run lintbun run typecheck— 46 tasks passedTURBO_TEST_CONCURRENCY=1 bun run test --continue=always— 40 tasks passed; earlier intermittent failures passed on rerun without assertion or timeout changeschangeset status --since mainvalidates this branch's release planThe existing cloud MCP browser-approval org-scope scenario remains skipped because its OAuth test setup times out before the assertions. The full repository release plan separately has an existing mixed ignored-package error in
computer-use-remembered-approvals; this branch does not change that changeset.Checklist