Skip to content

Start the org-slug inheritance test on the slugged URL #2161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RhysSullivan merged 1 commit into from
Sep 30, 2026
Merged

Start the org-slug inheritance test on the slugged URL #2161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/react/src/org-slug-routing.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,10 @@ type RouteMatch = { readonly routeId: string; readonly params: Record<string, st
type SpikeRouter = {
matchRoutes(pathname: string): ReadonlyArray<RouteMatch>;
buildLocation(options: unknown): { readonly href: string };
navigate(options: unknown): Promise<void>;
load(): Promise<void>;
};

const make = (): SpikeRouter => {
const make = (initialPath = "/"): SpikeRouter => {
const rootRoute = createRootRoute();
const orgScope = createRoute({
getParentRoute: () => rootRoute,
Expand All @@ -38,7 +37,7 @@ const make = (): SpikeRouter => {
// oxlint-disable-next-line executor/no-double-cast -- boundary: a test-local route tree must escape the package-global router Register types
return createRouter({
routeTree,
history: createMemoryHistory({ initialEntries: ["/"] }),
history: createMemoryHistory({ initialEntries: [initialPath] }),
}) as unknown as SpikeRouter;
};

Expand Down Expand Up @@ -84,8 +83,9 @@ describe("optional org-slug segment", () => {
});

it("inherits the slug param on relative navigations", async () => {
const router = make();
await router.navigate({ to: "/{-$orgSlug}", params: { orgSlug: "acme" } });
// Start on the slugged URL: without a DOM the router runs in server mode,
// where navigate() does not move the location.
const router = make("/acme");
await router.load();
// A link that only supplies its own params keeps the current orgSlug.
const href = router.buildLocation({
Expand Down
Loading