Skip to content

fix(api): accept is_server in S3Storage so v1 asset endpoints stop 500ing #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thestumonkey merged 1 commit into from
Sep 13, 2026
Merged

fix(api): accept is_server in S3Storage so v1 asset endpoints stop 500ing #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion apps/api/plane/settings/storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,15 @@ def url(self, name, parameters=None, expire=None, http_method=None):

"""S3 storage class to generate presigned URLs for S3 objects"""

def __init__(self, request=None):
def __init__(self, request=None, is_server=False):
# `is_server` is passed by the three public-API asset views
# (plane/api/views/asset.py) but was never accepted here, so every call
# to GET /api/v1/workspaces/{slug}/assets/{id}/ and the two upload
# endpoints raised TypeError and answered 500. It is accepted and
# currently has no effect: those callers hand the presigned URL to a
# client OUTSIDE Plane's network, so the public endpoint -- the existing
# behaviour -- is the correct one for them anyway.
self.is_server = is_server
# Get the AWS credentials and bucket name from the environment
self.aws_access_key_id = os.environ.get("AWS_ACCESS_KEY_ID")
# Use the AWS_SECRET_ACCESS_KEY environment variable for the secret key
Expand Down
Loading