Repository navigation
refactor: remove duplicated POD scientific modules - #17
Merged
Merged
Conversation
Use siderust::pod as the canonical POD implementation and keep spod focused on service orchestration, adapters, and artifacts.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 30f3fa2e59
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Use Siderust variational propagation, emit valid run provenance, remove unsupported ambiguity configuration, delete stale compatibility paths and documentation, and add synthetic service integration coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8
Summary
This refactor makes
spoda service/application on top of the canonical Siderust 0.12 POD APIs rather than a second scientific POD toolkit.Scientific consolidation
core,dynamics,estimation,observations,products, andqcimplementations and their obsolete exports/tests.siderust::pod::propagation::VariationalPropagator; the initial state and identity STM are explicitly aligned with observation epoch zero.Service boundaries and provenance
DatasetRef.request.jsonin the run directory and hash that real file for manifest provenance.third_body: trueconfigurations are rejected rather than silently running a TwoBody/J2-only model.RunManifestmetadata with real SHA-256 configuration provenance, RFC3339 start/finish timestamps, deterministic references, and hashed output byte counts.spod::serviceno longer re-exports reusable scientific state types; internal callers import them directly from Siderust.Cleanup
SIDERUST_POD_REST_BIND/SIDERUST_POD_REST_OUTcompatibility.siderust::formats::spice::{daf, spk}directly whilespod::spicekeeps only value-added kernel/provider functionality.Tests and validation
tests/service_synthetic.rs, coveringRunConfig -> runner -> Siderust variational propagation/estimation -> products/QC -> RunManifest, including estimator output, required manifest fields, timestamps, configuration hash, output existence, and hash/byte-count consistency.sp3,rinex_obs,rinex_nav, andantexare all rejected while real-data ingestion is unsupported.The former standalone scientific API is intentionally not preserved through compatibility façades. Reusable POD science belongs upstream in Siderust; this PR keeps concrete service orchestration and external-format boundaries in
spod.