Skip to content

refactor: remove duplicated format and orbital-mechanics implementations - #18

Merged
VPRamon merged 5 commits into
mainfrom
9-remove-duplicated-format-orbital-mechanics
Oct 4, 2026
Merged

VPRamon merged 5 commits into
mainfrom
9-remove-duplicated-format-orbital-mechanics

Conversation

@VPRamon

@VPRamon VPRamon commented Oct 4, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Remove duplicated local standard-format and TLE/OMM implementations in favor of canonical Siderust 0.12 APIs.
  • Remove duplicated generic SPICE parsing/evaluation and Lambert from the core spod product; Lambert is intentionally outside the current operational service scope.
  • Keep the POD service pipeline, artifacts, provenance, CLI/REST interfaces, and synthetic reference workflow on Siderust.
  • Retain full Vallado-style SGP4/SDP4 locally, including its backend dependency, probe workspace, executable example, and Vallado regression coverage.
  • Do not restore LISA, DORIS, de440, or Parquet compatibility features without a concrete current service workflow; LISA remains an upstream/reference use case rather than a core Cargo feature.

The local SGP4/SDP4 implementation is an explicit temporary upstream-gap exception. Siderust 0.12 does not yet provide semantic parity with the full Vallado/AFSPC implementation, so this PR does not substitute siderust::astro::sgp4 or silently downgrade numerical behavior. Migration is tracked by spod #29 and Siderust/siderust#98; the local implementation can be removed in a later migration PR after parity lands upstream.

This PR partially addresses #9: format/TLE/SPICE/Lambert ownership is consolidated, while full SGP4/SDP4 consolidation remains deferred to #29 and Siderust/siderust#98.

Validation

  • cargo fmt --all -- --check
  • locked workspace checks and strict Clippy
  • default, no-default-feature, and all-feature workspace tests
  • Vallado near-Earth, deep-space, and propagation-error regression tests
  • cargo run --example 04_sgp4_from_tle
  • documentation tests and cargo doc with broken-link denial
  • dependency graph, TODO, and legacy-name guards
  • cargo deny --all-features check
  • cargo run --quiet --bin spod -- run examples/configs/leo_gnss_mvp1.yaml

VPRamon and others added 5 commits October 4, 2026 21:11
Remove unused local format, TLE, SGP4, Lambert, and SPICE implementations and their examples and probe workspace. Keep the service pipeline on canonical Siderust APIs without compatibility facades.\n\nCloses #9\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Restore the local SGP4/SDP4 backend, probe, example, and Vallado regression coverage while adapting inputs to Siderust's canonical TLE records. Document the upstream parity gap and leave generic format, SPICE, TLE, and Lambert consolidation intact.\n\nPartially addresses #9.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Document the retained Vallado regression vectors as a temporary upstream-gap contract and remove stale Siderust ownership claims.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@VPRamon
VPRamon merged commit 9b7053d into main Oct 4, 2026
14 checks passed
@VPRamon
VPRamon deleted the 9-remove-duplicated-format-orbital-mechanics branch October 4, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant