Repository navigation
refactor: remove duplicated format and orbital-mechanics implementations - #18
Merged
Merged
Conversation
Remove unused local format, TLE, SGP4, Lambert, and SPICE implementations and their examples and probe workspace. Keep the service pipeline on canonical Siderust APIs without compatibility facades.\n\nCloses #9\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Restore the local SGP4/SDP4 backend, probe, example, and Vallado regression coverage while adapting inputs to Siderust's canonical TLE records. Document the upstream parity gap and leave generic format, SPICE, TLE, and Lambert consolidation intact.\n\nPartially addresses #9.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Document the retained Vallado regression vectors as a temporary upstream-gap contract and remove stale Siderust ownership claims.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spodproduct; Lambert is intentionally outside the current operational service scope.The local SGP4/SDP4 implementation is an explicit temporary upstream-gap exception. Siderust 0.12 does not yet provide semantic parity with the full Vallado/AFSPC implementation, so this PR does not substitute
siderust::astro::sgp4or silently downgrade numerical behavior. Migration is tracked by spod #29 and Siderust/siderust#98; the local implementation can be removed in a later migration PR after parity lands upstream.This PR partially addresses #9: format/TLE/SPICE/Lambert ownership is consolidated, while full SGP4/SDP4 consolidation remains deferred to #29 and Siderust/siderust#98.
Validation
cargo fmt --all -- --checkcargo run --example 04_sgp4_from_tlecargo docwith broken-link denialcargo deny --all-features checkcargo run --quiet --bin spod -- run examples/configs/leo_gnss_mvp1.yaml