Repository navigation
Rebuild integration tests and CI around the service architecture - #38
Merged
Merged
Conversation
Consolidate service-oriented test documentation and lifecycle/artifact assertions, add source hygiene enforcement, and make CI dependency-locked. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 663a1d437d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Exclude only src/sgp4 explicitly, distinguish grep matches from checker errors, and make the unknown-field configuration test isolate deny_unknown_fields diagnostics. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Cover restricted Rust visibility forms, the exact src/sgp4 exception boundary, and checker failures in temporary fixture trees. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #12
This PR aligns the test and CI strategy with the post-#10/#11 service architecture.
What changed
spodowns configuration, orchestration, lifecycle, artifacts, provenance, CLI, REST, and deployment-boundary tests.scripts/check_architecture.sh, a narrowly scoped source-pattern guard against new local generic scientific implementation types. It is not a filename blacklist and explicitly excludes the documentedsrc/sgp4/exception.spod -> Siderust 0.12architecture.--lockedwhere reproducibility matters, and wired the architecture guard into project guards.Validation
Passed locally:
cargo fmt --all -- --checkcargo check --locked --workspace --all-targets --all-featurescargo clippy --locked --workspace --all-targets --all-features -- -D warnings--no-default-features, and--all-featuresworkspace test matricescargo test --locked --doc --workspace --all-featurescargo doc --locked --workspace --no-depscargo deny --all-features checkexamples/configs/leo_gnss_mvp1.yamlThe PR does not add scientific algorithms, real-data POD, persistence, authentication, or SGP4 upstream parity work.