Repository navigation
X11: select one monitor with UU_X11_MULTISCREEN=1 (#98) - #100
Merged
Merged
Conversation
X11 sends the whole root, so side-by-side monitors arrive as one wide picture. With UU_X11_MULTISCREEN=1 the host lists the RandR monitors (xrandr --listmonitors, read at start; primary or UU_X11_OUTPUT first, then left to right) through the existing Hyprland screen-switch path. x11grab reads display+x,y at the monitor size, XTest/uinput absolute input adds the monitor offset, and the in-process engine and the xrandr resize are skipped while a monitor region is captured (分辨率 scales the stream). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes nothing yet: #98 stays open until the reporter confirms on real hardware.
X11 captures the whole root window, so two side-by-side monitors reach the viewer as one 3840×1080 picture. This adds an opt-in mode (default off, single-screen hosts unchanged):
UU_X11_MULTISCREEN=1: monitors come fromxrandr --listmonitors(read once at start, two or more required). The primary, orUU_X11_OUTPUT, is id 0; the rest go left to right. They are advertised and switched through the existing screen-switch path used for Hyprland (wayland::outputs/select, CaptureSettingRequest field 4 / SimpleAction 8screen_id).display+x,yat the monitor size. The in-process engine (inproc-av, not in release builds) is skipped while a region is captured.sync_native).Verification:
x11_monitors_keep_their_root_offsets(the xrandr output from X11 双显示器被拼接为一张画面，希望支持单屏选择/切换 #98, virtual monitors, preferred output, malformed lines).cargo test246 passed on macOS and on Debian 13.absolute_pointer_lands_on_the_selected_x11_monitorpasses (pointer lands at monitor offset + mapped point for both monitors, switching back and forth).x11grabwith:N+0,0/:N+1920,0returns the left (red) and right (blue) halves respectively.🤖 Generated with Claude Code