Skip to content

Remove YaPB bots from cs16-client - #426

Closed
jeefo wants to merge 1 commit into
Velaron:mainfrom
jeefo:deprecate-yapb
Closed

jeefo wants to merge 1 commit into
Velaron:mainfrom
jeefo:deprecate-yapb

Conversation

@jeefo

@jeefo jeefo commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

This PR removes YaPB bots from cs16-client.

Reasons for removal:

  1. Maintenance burden: I am unable to provide timely fixes for new issues as they arise (e.g., the recent fdsan problem).
  2. APK size: The YaPB binary alone is larger than all other binaries in the APK combined, so reducing its size is a nice bonus.
  3. Training mode breakage: YaPB breaks training mode (bots are not intended to work there) due to missing exports.
  4. User experience: Users report problems with the bots. Although an option to disable them exists, many users are unable or fail to use it, leading to continued complaints.

@a1batross

Copy link
Copy Markdown
Collaborator

F.

@Vladislav4KZ

Copy link
Copy Markdown
Contributor

Maybe it would indeed be worth removing YaPB from CS16Client, but I wouldn't want to completely drop Android support. Perhaps YaPB could be made into a separate module instead of being part of CS16Client.

And I'm not asking you to do this specifically. I'd like to try doing it myself.

Also, that fdsan-related crash only occurred for one person, and I'm not even sure they were using the original CS16Client. At the very least, they definitely have some kind of custom engine build installed, so I wouldn't rule out the possibility that CS16Client itself may have been modified as well.

For some reason, I haven't experienced any crashes on Android with the current version of YaPB that is used in CS16Client.

@jeefo

jeefo commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

Maybe it would indeed be worth removing YaPB from CS16Client, but I wouldn't want to completely drop Android support. Perhaps YaPB could be made into a separate module instead of being part of CS16Client.

And I'm not asking you to do this specifically. I'd like to try doing it myself.

Also, that fdsan-related crash only occurred for one person, and I'm not even sure they were using the original CS16Client. At the very least, they definitely have some kind of custom engine build installed, so I wouldn't rule out the possibility that CS16Client itself may have been modified as well.

For some reason, I haven't experienced any crashes on Android with the current version of YaPB that is used in CS16Client.

Android support in the main repository will remain intact. The separate module looks good. Or we could go back to what @Velaron did: subvendor the repository into its own fork to prevent breakage from upstream, and set yb_quota to 0 by default.

@jeefo jeefo closed this Oct 15, 2026
@jeefo
jeefo deleted the deprecate-yapb branch October 15, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants