feat(ngts): add Cloud/NGTS certificate revocation via GraphQL#207
Open
TomaszSwierszczCA wants to merge 1 commit into
Open
feat(ngts): add Cloud/NGTS certificate revocation via GraphQL#207TomaszSwierszczCA wants to merge 1 commit into
TomaszSwierszczCA wants to merge 1 commit into
Conversation
TomaszSwierszczCA
requested review from
luispresuelVenafi and
tr1ck3r
as code owners
stkomitov
approved these changes
Jul 2, 2026
Implement revoke_cert on CloudConnection using a new _graphql helper that POSTs the GraphQL revokeCertificate mutation; NGTSConnection inherits it unchanged (Bearer auth + .../ngts/graphql via its _post override). Thumbprint-keyed (Go parity): thumbprint required and uppercased, disable ignored, ca_compromise rejected. Add CertificateRevokeError and an optional RevocationRequest.ca_account_name (resolved to a CA-account id via ListCAAccounts). Add offline unit tests plus live NGTS/VaaS revoke tests (skip when the zone CA cannot revoke). Document revoke in README-NGTS.md and bump version to 0.21.0.
TomaszSwierszczCA
force-pushed
the
add-revocation-ngts
branch
from
b4bf3fc to
2f34e9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement revoke_cert on CloudConnection using a new _graphql helper that POSTs the GraphQL revokeCertificate mutation; NGTSConnection inherits it unchanged (Bearer auth + .../ngts/graphql via its _post override). Thumbprint-keyed (Go parity): thumbprint required and uppercased, disable ignored, ca_compromise rejected. Add CertificateRevokeError and an optional RevocationRequest.ca_account_name (resolved to a CA-account id via ListCAAccounts). Add offline unit tests plus live NGTS/VaaS revoke tests (skip when the zone CA cannot revoke). Document revoke in README-NGTS.md and bump version to 0.21.0.