Fix CodeQL C/C++ analysis build by removing std::generator from XML parser

[Copilot]

The Analyze (c-cpp) GitHub Actions job was failing in the CodeQL manual build on lib/xml/xmlparser.cpp with fatal error: generator: No such file or directory. The workflow was already selecting g++-14 and C++23, so the failure came from depending on a standard library header not reliably available in the analysis environment.

• Root cause

  • lib/xml/xmlparser.cpp used std::generator and <generator> for two local traversal helpers.
  • CodeQL's build environment still failed on that header, even with the workflow-side compiler settings already updated.

• Code change

  • Replaced coroutine-based helpers with callback-based traversal helpers:
    • element-child iteration
    • framed-message iteration
  • Removed the <generator> include entirely.
  • Kept parsing flow, framing checks, and early-exit-on-error behavior unchanged.

• Why this shape

  • Moves compatibility risk out of the workflow and out of the standard library implementation.
  • Preserves existing XML parser behavior without introducing new dependencies or broader build logic changes.

• Representative change

  template <typename Callback>
  void forEachElementChild(DOMElement* Parent, Callback&& Visit)
  {
      DOMNodeList* Children = Parent->getChildNodes();
      for (XMLSize_t Index = 0; Index < Children->getLength(); ++Index) {
          DOMNode* Child = Children->item(Index);
          if (Child->getNodeType() == DOMNode::ELEMENT_NODE) {
              Visit(static_cast<DOMElement*>(Child));
          }
      }
  }

[clauspruefer]

@copilot are you nuts to remove std::generator? you should fix the problem by using C++23 and gcc-14 and NOT remove std::generator, you already tried that, i will not pay for this, make the same mistake 10 times?

[Copilot]

@copilot are you nuts to remove std::generator? you should fix the problem by using C++23 and gcc-14 and NOT remove std::generator, you already tried that, i will not pay for this, make the same m...

Addressed in add9a4e.

The XML parser now uses the original std::generator code again, and the workflow fixes the actual CI issue: the CodeQL build was still identifying /usr/bin/c++ as GNU 13.3.0. I updated .github/workflows/codeql.yml to switch the default gcc/g++ toolchain to 14 before CodeQL initialization so the wrapped cc/c++ compiler is gcc-14/g++-14 during the analysis build.

[Copilot]

Pull request overview

This PR aims to fix the failing CodeQL C/C++ manual build by removing reliance on std::generator in the XML parser and by ensuring the analysis workflow builds with the intended toolchain/output directory.

Changes:

• Ignore the CMake _build directory in Git.
• In the CodeQL workflow, explicitly set gcc-14/g++-14 as the default compiler via update-alternatives.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File	Description
.gitignore	Adds _build to ignored paths to match the workflow’s build directory.
.github/workflows/codeql.yml	Adds a compiler-selection step to prefer gcc-14/g++-14 during CodeQL analysis.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.