Fix CodeQL workflow: drop update-alternatives, pass gcc-14 directly to cmake - #214
Merged
Merged
Conversation
…cmake Co-authored-by: clauspruefer <17313789+clauspruefer@users.noreply.github.com>
Copilot
AI
changed the title
Fix CodeQL workflow: remove update-alternatives, use explicit gcc-14 paths
Fix CodeQL workflow: drop update-alternatives, pass gcc-14 directly to cmake
Aug 14, 2026
Copilot created this pull request from a session on behalf of
clauspruefer
August 14, 2026 09:22
View session
clauspruefer
marked this pull request as ready for review
August 14, 2026 09:42
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the repository’s custom CodeQL workflow to reliably use GCC 14 for the C/C++ build without mutating system-wide compiler symlinks, aligning the workflow with the project’s C++23 requirement (<generator>).
Changes:
- Removed the
update-alternativesstep that globally rewiredgcc/g++/cc/c++. - Removed
CC/CXXenvironment overrides in the build step. - Configured CMake to use
/usr/bin/gcc-14and/usr/bin/g++-14directly via-DCMAKE_*_COMPILER.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lib/xml/xmlparser.cppuses#include <generator>(C++23std::generator), available only in gcc-14+. The previous fix installed gcc-14 but routed it throughupdate-alternativesto override system symlinks — a fragile indirection that also had no effect on GitHub's parallel dynamic code scanning run, which uses its own autobuild runner.Changes
update-alternativesacross all fourgcc/g++/cc/c++aliases)CC/CXXenv vars from the Build stepNote on the dynamic scan
The linked failing job (
runs/31785672753) is GitHub's default code scanning (dynamic/github-code-scanning/codeql), which runs independently of this workflow using autobuild with system gcc-13. That cannot be fixed via repository files. To stop it: Settings → Security → Code scanning → Default setup → Disable. Our custom workflow already handles analysis correctly.