Skip to content

Update wasi-sdk-34 in CI #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexcrichton merged 1 commit into from
Aug 20, 2026
+4 −8
Merged

Update wasi-sdk-34 in CI #873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,19 +132,19 @@ jobs:

- name: Test wasm32-wasip3 (debug)
os: ubuntu-24.04
clang_version: wasi-sdk-34.0-rc.2
clang_version: wasi-sdk-34.0-rc.3
test: true
args: -DCMAKE_BUILD_TYPE=Debug -DTARGET_TRIPLE=wasm32-wasip3

- name: Test wasm32-wasip3 coop-threads
os: ubuntu-24.04
clang_version: wasi-sdk-34.0-rc.2
clang_version: wasi-sdk-34.0-rc.3
test: true
args: -DTARGET_TRIPLE=wasm32-wasip3 -DENABLE_COOP_THREADS=ON

- name: Test wasm32-wasip3 coop-threads (debug)
os: ubuntu-24.04
clang_version: wasi-sdk-34.0-rc.2
clang_version: wasi-sdk-34.0-rc.3
test: true
args: -DCMAKE_BUILD_TYPE=Debug -DTARGET_TRIPLE=wasm32-wasip3 -DENABLE_COOP_THREADS=ON

Expand Down Expand Up @@ -309,7 +309,7 @@ jobs:
clang_version: wasi-sdk-32.0
- name: wasm32-wasip3 coop-threads
args: -DTARGET_TRIPLE=wasm32-wasip3 -DENABLE_COOP_THREADS=ON
clang_version: wasi-sdk-34.0-rc.2
clang_version: wasi-sdk-34.0-rc.3
steps:
- uses: actions/checkout@v6
with:
Expand Down
4 changes: 0 additions & 4 deletions libc-top-half/headers/private/wasi/wasip3_tls.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,7 @@ static inline void *__wasilibc_tls_main_thread_base(void) {
return (void *)info->main_thread_tls_base;
void *ret;
__asm__(
#ifdef __PIC__
".globaltype __init_tls_base, i32\n"
#else
".globaltype __init_tls_base, i32, immutable\n"
#endif
"global.get __init_tls_base\n"
"local.set %0\n"
: "=r"(ret));
Expand Down