Skip to content

fix(watchdog): avoid descriptive stop-intent false positives - #455

Merged
Wibias merged 4 commits into
mainfrom
fix/watchdog-stop-intent-false-positive
Sep 17, 2026
Merged

Wibias merged 4 commits into
mainfrom
fix/watchdog-stop-intent-false-positive

Conversation

@Wibias

@Wibias Wibias commented Sep 16, 2026

Copy link
Copy Markdown
Owner

Summary

Fix a Codex hook-mode false positive where descriptive review prose such as Running the candidate scanner ... was treated as an explicitly selected next tool action, causing an unnecessary GitHub Delivery recovery 1/3 continuation at an otherwise valid final stop.

Root cause

The broad stream watchdog intentionally treats imperative-looking Running / Executing clauses as tool-emission signals so it can detect repeated narration stalls. Stop-hook logic incorrectly reused any newly observed broad signal as proof that the assistant had selected an immediate next action.

That conflated descriptive gerunds with explicit commitments. The first correction then became too strict in the opposite direction: it no longer recovered for standalone commitments such as I will run ..., and it only scanned line starts, missing commitments after terminal sentences on the same line.

Fix

  • keep the broad stream detector unchanged
  • give Stop-hook recovery a narrower explicit-action commitment matcher
  • split Stop text into sentence clauses as well as lines, so No further action is authorized. Let me read ... is still contradictory and must recover
  • preserve recovery when the assistant explicitly commits to an action even without terminal wording
  • allow descriptive Running ... clauses to finalize normally

TDD

RED-first regression reproduced the 2026-09-16 incident while preserving the broad stream signal. Existing terminal-stop regressions exposed the over-strict first implementation, including standalone I will run ... and same-line post-terminal commitments.

On the current head, canonical repository checks and Node 22 compatibility are green. Dependency Review and Windows trace bins are also green; CodeQL is still running.

Scope

Two files only: the Stop-hook implementation and the incident regression test. No merge is performed by this PR.

@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 4c75a90f-3203-4dfd-8845-4eb7e5100de9


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Wibias
Wibias marked this pull request as ready for review September 17, 2026 00:23
@Wibias
Wibias merged commit 0456cc1 into main Sep 17, 2026
13 checks passed
@Wibias
Wibias deleted the fix/watchdog-stop-intent-false-positive branch September 17, 2026 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant