fix(update): safely replace reviewed local drift - #459
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Wibias
marked this pull request as ready for review
September 20, 2026 14:22
Wibias
enabled auto-merge
September 20, 2026 14:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix self-update handling for managed installations with local drift.
Two safe paths are added:
npx github-delivery update --apply --replace-local-modificationsThe explicit path keeps
--forcedisabled and uses the existing staged install + full-installation backup/rollback machinery.Why
The uploaded installation showed a mixed state: the compatibility redirect files already match changes shipped in 1.5.4, while the main installed
SKILL.mdis an intermediate local state rather than byte-identical to the current release. Treating every installed-manifest mismatch as permanently unreplaceable leaves such installations unable to return to the verified release line.Safety boundary
Default behavior remains fail-closed.
Automatic convergence requires:
changedorlocal_fileMissing files, mode changes, non-regular substitutions, target-absent files, and different content remain blocking.
The explicit replacement flag:
update --applyforceTDD evidence
Initial RED on
132d103cd3b75090750bd5b785d8887af67652c5:blocked_local_modificationsExplicit-authorization RED on
1d7a8f3b53209a7d9775fa8ad42d53879799ec0d:--replace-local-modificationsCurrent implementation head:
308222e86b43be4505e7cf38d10d178b8fb88e74.Current verification:
Release impact
Because this PR adds the new supported public CLI option
--replace-local-modifications, its highest observable SemVer impact is MINOR. The follow-up release after v1.5.4 is therefore1.6.0, not1.5.5. PR #458 is also unreleased and belongs in that same release delta.Scope
Self-update planning, explicit update authorization wiring, focused regressions, and user-facing update documentation.
No merge, tag, GitHub Release, npm publication, or release publication is authorized by this PR.