Skip to content

fix(controller): persist created PR identity - #462

Merged
Wibias merged 3 commits into
mainfrom
fix/controller-create-pr-reconcile
Sep 20, 2026
Merged

Wibias merged 3 commits into
mainfrom
fix/controller-create-pr-reconcile

Conversation

@Wibias

@Wibias Wibias commented Sep 20, 2026

Copy link
Copy Markdown
Owner

Summary

Persist the verified pull-request number into the workflow controller after a successful create_pr mutation.

Trace evidence

The newest Grok trace successfully created and live-verified PR #391, but the persisted controller checkpoint still contained pr: null.

Root cause

reconcileMutationResult() only reconciled successful push_code receipts into headSha. Completed create_pr receipts were recorded for publication completeness but their verified PR identity was never applied to controller refs.

Fix

  • reconcile completed create_pr results for the routed repository
  • use the broker's verified/idempotent PR number
  • reject ambiguous multi-PR reconciliation
  • preserve existing push reconciliation semantics

Focused regression coverage asserts that a verified successful create_pr changes checkpoint pr to the created number.

No merge or release publication is authorized by this PR.

@coderabbitai

coderabbitai Bot commented Sep 20, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: c5f1388e-6492-4d0b-b058-73226a6520e1


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Wibias
Wibias marked this pull request as ready for review September 20, 2026 22:40
@Wibias
Wibias enabled auto-merge September 20, 2026 22:40
@Wibias
Wibias merged commit 5bdbbbe into main Sep 20, 2026
13 checks passed
@Wibias
Wibias deleted the fix/controller-create-pr-reconcile branch September 20, 2026 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant