Skip to content

fix(workflow): reject abbreviated base SHA identities - #465

Merged
Wibias merged 3 commits into
mainfrom
fix/workflow-bootstrap-base-sha
Sep 20, 2026
Merged

Wibias merged 3 commits into
mainfrom
fix/workflow-bootstrap-base-sha

Conversation

@Wibias

@Wibias Wibias commented Sep 20, 2026

Copy link
Copy Markdown
Owner

Summary

Reject abbreviated or otherwise non-canonical base SHAs at local-PR workflow bootstrap instead of allowing them to surface later as a misleading checkpoint base mismatch.

Trace evidence

The newest Grok trace invoked bootstrap with the abbreviated base 35b190a05 while the existing checkpoint stored the full base identity. The resulting workflow_bootstrap_checkpoint_base_mismatch sent the agent into checkpoint-recovery investigation even though the immediate caller error was simply a short SHA.

Fix

  • validate baseSha with the same exact 40–64 hex identity contract used for headSha
  • normalize accepted base identities before storing/comparing them
  • fail immediately with workflow_bootstrap_base_invalid for abbreviated input

This prevents a bad bootstrap argument from being mistaken for corrupt or conflicting persisted state.

No merge or release publication is authorized by this PR.

@coderabbitai

coderabbitai Bot commented Sep 20, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 577246bc-6da1-4c51-90d6-f17c0a98f67c


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Wibias
Wibias marked this pull request as ready for review September 20, 2026 22:35
@Wibias
Wibias enabled auto-merge September 20, 2026 22:35
@Wibias
Wibias merged commit b968dae into main Sep 20, 2026
13 checks passed
@Wibias
Wibias deleted the fix/workflow-bootstrap-base-sha branch September 20, 2026 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant