fix(workflow): reject abbreviated base SHA identities - #465
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Wibias
marked this pull request as ready for review
September 20, 2026 22:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject abbreviated or otherwise non-canonical base SHAs at local-PR workflow bootstrap instead of allowing them to surface later as a misleading checkpoint base mismatch.
Trace evidence
The newest Grok trace invoked bootstrap with the abbreviated base
35b190a05while the existing checkpoint stored the full base identity. The resultingworkflow_bootstrap_checkpoint_base_mismatchsent the agent into checkpoint-recovery investigation even though the immediate caller error was simply a short SHA.Fix
baseShawith the same exact 40–64 hex identity contract used forheadShaworkflow_bootstrap_base_invalidfor abbreviated inputThis prevents a bad bootstrap argument from being mistaken for corrupt or conflicting persisted state.
No merge or release publication is authorized by this PR.