Repository navigation
Conversation
The generated entries piped through 'tee' unconditionally, so the pipeline exit status came from tee and supercronic always saw success even when the scheduled job failed. Wrap the pipeline in bash -c with 'set -o pipefail' (bash ships in this image) so failures propagate to supercronic while output still lands in the per-run log file.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🐳 The image based on 808b6d34 commit has been built with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
teeunconditionally, so the pipeline exit status came fromtee: supercronic saw exit 0 even when the scheduled job failed (reproduced: innersh -c 'false; exit 7'reported as 0).bash -c 'set -o pipefail; ... | tee ...'(bash ships in this image), preserving the job's exit status while keeping the per-run log file behavior identical.docker exec+ supercronic-faithful harness: failing job -> supercronic sees 7; passing job -> 0; both still logged.Jira: SLOP-237
Test plan
shellcheck -x --shell=sh update_cron.shcleanbash -n update_cron.shcleansupercronic -test