Repository navigation
Render block-insert pending state - #77973
adamsilverstein wants to merge 5 commits into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +98 B (0%) Total Size: 7.52 MB 📦 View Changed
|
|
Flaky tests detected in 6125134. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/28184704005
|
5d8bf4c to
a56df58
Compare
43aa1d1 to
e1d5977
Compare
a56df58 to
f083328
Compare
e1d5977 to
2968668
Compare
f083328 to
9a1fb2d
Compare
2968668 to
ba2a3b7
Compare
9a1fb2d to
4cd8b0d
Compare
ba2a3b7 to
37984e4
Compare
4cd8b0d to
e2f987d
Compare
37984e4 to
96a19c0
Compare
…debar Brings the visual treatment for block-insert-after suggestions: - style.scss adds the pending-insert treatment: 70% opacity plus a dashed green outline. The dashed style distinguishes it from the solid bracket used by pending attribute edits — both treatments can apply to the same block when a user inserts and then immediately edits its attributes. - suggestion-summary.js adds an "Insert block: <name>" line via the same friendlyBlockName helper that handles block-remove. Falls back to "block" when the op carries no name. - suggestion-diff.js adds BlockInsertDiff, which renders the captured block snapshot's text via collectBlockText with <ins> styling. When the inserted block has no text yet (an empty paragraph), falls back to a "New block: <name>" label so the sidebar isn't blank. Refs #77434.
e2f987d to
7925cae
Compare
96a19c0 to
26727b9
Compare
…' into suggest-mode-6b-insert-ui
|
Superseded by the fresh-stack restructure of Suggest mode (#73411). The feature has been re-sliced from this 16-deep stack onto current
The whole feature now sits behind a Suggestion Mode experiment (Settings → Experiments → Collaboration). Closing in favour of the new stack — details: #73411 (comment) |
What
Adds the visual treatment for block-insert-after suggestions (#77434, task 6b). Pairs with the mechanism PR (#77971).
metadata.suggestion = { type: 'pending-insert' }renders at 70% opacity with a dashed green outline.How
style.scss: pending-insert styling (70% opacity + dashed green outline).suggestion-summary.js: handlesblock-insert-afterops with an "Insert block: " line.suggestion-diff.js:BlockInsertDiffrenders the captured snapshot viacollectBlockTextwith<ins>styling.Testing
Stack
Refs #77434, #73411.