Repository navigation
Apply/Reject controls in the collaboration sidebar - #78353
adamsilverstein wants to merge 8 commits into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +781 B (+0.01%) Total Size: 7.51 MB 📦 View Changed
|
|
Flaky tests detected in ff0fed1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/28184512201
|
Wire icon-only Apply / Reject controls into the note header and a shared useSuggestionDecision hook into the note body so the staleness dialog and resolution state stay consistent. Notes carrying a _wp_suggestion payload now render the SuggestionSummary in the thread, and block-notes and editor-intent-switcher e2e specs cover the new sidebar UI.
… phase-5b-collab-sidebar-actions
… phase-5b-collab-sidebar-actions
… phase-5b-collab-sidebar-actions
… phase-5b-collab-sidebar-actions
… phase-5b-collab-sidebar-actions # Conflicts: # test/e2e/specs/editor/various/editor-intent-switcher.spec.js
The 'Inline notes › highlights an inline marker with the author color at the rest opacity' e2e test exercises the per-author inline-marker tinting feature (note-highlight-styles.js), which is introduced downstream on the autosave branch. This branch has no inline-mark rendering, so the 'Add note' rich-text entry the test relies on never appears and the test times out. Move the coverage to the branch that owns the feature; it remains on autosave and below where it passes.
|
Superseded by the fresh-stack restructure of Suggest mode (#73411). The feature has been re-sliced from this 16-deep stack onto current
The whole feature now sits behind a Suggestion Mode experiment (Settings → Experiments → Collaboration). Closing in favour of the new stack — details: #73411 (comment) |
Overview
One of three replacement PRs for the now-closed #77407. This slice wires Apply / Reject sidebar UI on top of the summary + attribute-conflict work from #78352.
Tracking issue: #73411.
What's in this PR
Collaboration sidebar
useSuggestionDecisionhook insuggestion-actions.js— A single source of truth for Apply / Reject behavior. Both the note header (icon buttons) and the note body (resolution state, staleness dialog) read from the same hook, so their behavior cannot diverge.check,closeSmallicons from@wordpress/icons).SuggestionSummaryplus the staleness confirmation dialog whenhasAttributeConflictreturns true.utils.js— helpers shared between note components for reading the suggestion-related metadata.Tests
test/utils.jsextended for the new helpers.block-notes.spec.js(new spec covering Apply / Reject flows) andeditor-intent-switcher.spec.js(snackbar assertions).Test plan
Manual:
hasAttributeConflict).Replaces part of #77407.
🗺️ PR Stack Navigation
_wp_suggestionmeta, provider, sidebar actions📋 Tracking issue: #73411