Repository navigation
Framework: Update the AI development job to Node.js 24 - #82665
Closed
manzoorwanijk wants to merge 3 commits into
Closed
manzoorwanijk wants to merge 3 commits into
manzoorwanijk wants to merge 3 commits into
Conversation
The Node.js 24 upgrade (#82370) left the `agent-development` job on Node 22. Run it on the repository version with Node 26 alongside, as the other jobs do, and raise the eval package's own floor to match so it no longer pins an older Node than the repository.
Keeps the Node.js and npm setup in one place, so the job follows the repository version instead of a pin of its own. The eval package's tree is excluded from the shared node_modules cache: it is not a workspace and installs from its own lockfile.
🤖 PR meta 🤖📦 Bundle sizeSize Change: 0 B Total Size: 8 MB
⚡ PerformanceShow the resultsClient side metrics exclude the server response time. front-end-block-theme
front-end-classic-theme
media-processing
media-upload
post-editor
site-editor
|
manzoorwanijk
requested review from
aduth,
ciampo,
desrosj,
jeryj and
jsnajdr
September 9, 2026 10:24
manzoorwanijk
marked this pull request as ready for review
September 9, 2026 10:24
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
With setup-node in place the job can take the version from `.nvmrc`, leaving the matrix to the operating systems. Node 26 coverage goes with it; the unit tests and the `check` job still run it.
Member
Author
|
Closing in favor of #82662 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
See #80812. Follow up to #82370. Moves the
agent-developmentjob instatic-checks.ymloff Node.js 22 and onto the repository version, and reuses thesetup-nodeaction there.Why?
The Node.js 24 upgrade missed this job: its own
actions/setup-nodepin and hardcoded matrix versions kept CI testing the eval package on a Node version the repository no longer supports.How?
The job no longer picks a Node version at all: the matrix is just the three operating systems, and
./.github/setup-nodetakes the version from.nvmrc. Node 26 coverage goes with it, andunit-test.ymland thecheckjob still run it.test/ai-developmentno longer pins an older Node than the repository, so its own.nvmrcis gone andengines.nodefollows the root. The eval package's tree is excluded from the sharednode_modulescache, since it is not a workspace and installs from its own lockfile. The added root install is why the timeout goes from 15 to 30 minutes.Testing Instructions
nvm use && PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD=1 npm ci --prefix test/ai-development && npm --prefix test/ai-development run test:utils && npm --prefix test/ai-development run validate.Use of AI Tools
Authored with Claude Code, reviewed by me.
🤖 Generated with Claude Code