Skip to content

Framework: Update the AI development job to Node.js 24 - #82665

Closed
manzoorwanijk wants to merge 3 commits into
trunkfrom
ci/update-remaining-node-22-jobs
Closed

manzoorwanijk wants to merge 3 commits into
trunkfrom
ci/update-remaining-node-22-jobs

Conversation

@manzoorwanijk

@manzoorwanijk manzoorwanijk commented Sep 9, 2026 •

Copy link
Copy Markdown
Member

What?

See #80812. Follow up to #82370. Moves the agent-development job in static-checks.yml off Node.js 22 and onto the repository version, and reuses the setup-node action there.

Why?

The Node.js 24 upgrade missed this job: its own actions/setup-node pin and hardcoded matrix versions kept CI testing the eval package on a Node version the repository no longer supports.

How?

The job no longer picks a Node version at all: the matrix is just the three operating systems, and ./.github/setup-node takes the version from .nvmrc. Node 26 coverage goes with it, and unit-test.yml and the check job still run it. test/ai-development no longer pins an older Node than the repository, so its own .nvmrc is gone and engines.node follows the root. The eval package's tree is excluded from the shared node_modules cache, since it is not a workspace and installs from its own lockfile. The added root install is why the timeout goes from 15 to 30 minutes.

Testing Instructions

  1. Confirm the AI development tests pass on all three operating systems in this PR's checks.
  2. Locally: nvm use && PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD=1 npm ci --prefix test/ai-development && npm --prefix test/ai-development run test:utils && npm --prefix test/ai-development run validate.

Use of AI Tools

Authored with Claude Code, reviewed by me.

🤖 Generated with Claude Code

The Node.js 24 upgrade (#82370) left the `agent-development` job on Node 22.
Run it on the repository version with Node 26 alongside, as the other jobs do,
and raise the eval package's own floor to match so it no longer pins an older
Node than the repository.
Keeps the Node.js and npm setup in one place, so the job follows the repository
version instead of a pin of its own. The eval package's tree is excluded from
the shared node_modules cache: it is not a workspace and installs from its own
lockfile.
@github-actions

github-actions Bot commented Sep 9, 2026 •

Copy link
Copy Markdown

🤖 PR meta 🤖

📦 Bundle size

Size Change: 0 B

Total Size: 8 MB

13b35f6 Run

⚡ Performance

Show the results

Client side metrics exclude the server response time.

front-end-block-theme

Metric 1d2dd1e trunk % Change
timeToFirstByte 58.55 ms +13.41% -4.18% 59.8 ms +7.94% -7.69% -2.09%
largestContentfulPaint 96 ms +8.33% -8.33% 94 ms +2.13% -6.38% 2.13%
lcpMinusTtfb 33.6 ms +21.73% -4.02% 31.25 ms +2.72% -5.6% 7.52%
wpBeforeTemplate 29.2 ms +18.05% -1.03% 29.03 ms +20.29% -4.17% 0.59%
wpTemplate 25.02 ms +1.6% -5.8% 24.42 ms +2.83% -2.99% 2.46%
wpTotal 54.89 ms +12.13% -4.48% 56.08 ms +6.21% -8.01% -2.12%
wpMemoryUsage 7.52 MB +0% -0% 7.48 MB +0% -0% 0.46%
wpDbQueries 17 +0% -0% 17 +0% -0% 0%

front-end-classic-theme

Metric 1d2dd1e trunk % Change
timeToFirstByte 40 ms +13.13% -1.5% 43.6 ms +10.44% -2.52% -8.26%
largestContentfulPaint 84 ms +7.14% -4.76% 88 ms +6.82% -0% -4.55%
lcpMinusTtfb 41 ms +6.34% -1.1% 44.4 ms +1.91% -3.49% -7.66%
wpBeforeTemplate 26.68 ms +16% -0.79% 26.17 ms +14.1% -1.83% 1.95%
wpTemplate 10.28 ms +8.17% -1.65% 14.11 ms +6.38% -1.2% -27.14%
wpTotal 37.17 ms +13.69% -1.48% 40.6 ms +10.54% -2.41% -8.45%
wpMemoryUsage 5.40 MB +0% -0% 5.47 MB +0% -0% -1.32%
wpDbQueries 10 +0% -0% 14 +0% -0% -28.57%

media-processing

Metric 1d2dd1e trunk % Change
mediaProcessingJpeg 407.53 ms +2.06% -0.69% 399.17 ms +0.64% -0.63% 2.09%
mediaProcessingAvif 6076.98 ms +0.25% -0.03% 6040.8 ms +0.6% -0.27% 0.6%
mediaProcessingJpegToAvif 4200.45 ms +0.25% -0.62% 4180.08 ms +0.21% -0.06% 0.49%

media-upload

Metric 1d2dd1e trunk % Change
jpegUploadProcessing 1439.65 ms +34.47% -0.89% 1426.11 ms +1.28% -0.7% 0.95%
pngUploadProcessing 211.27 ms +3.21% -6.5% 210.61 ms +2.1% -2.53% 0.31%
largeJpegUploadProcessing 1414.32 ms +0.41% -0.31% 1414.78 ms +0.35% -0.69% -0.03%
multipleImageUploadProcessing 1597.24 ms +7.73% -1.89% 1603.83 ms +7.35% -1.84% -0.41%

post-editor

Metric 1d2dd1e trunk % Change
serverResponse 404.78 ms +2.82% -7.52% 401.24 ms +2.05% -5.42% 0.88%
firstPaint 200.06 ms +39.2% -12.53% 206.83 ms +10.75% -18.72% -3.27%
domContentLoaded 1139.13 ms +1.34% -1.3% 1127.2 ms +1.18% -1.99% 1.06%
loaded 1140.28 ms +1.36% -1.29% 1128.33 ms +1.19% -2% 1.06%
firstContentfulPaint 372.85 ms +5.75% -12.26% 375.84 ms +3.74% -2.6% -0.8%
firstBlock 3024.71 ms +0.62% -1.06% 2974.68 ms +0.74% -0.82% 1.68%
type 14.56 ms +3.43% -5.08% 14.03 ms +5.56% -3.28% 3.78%
typeWithoutInspector 13.6 ms +10.37% -3.09% 13.86 ms +2.53% -4.91% -1.88%
typeWithTopToolbar 17.05 ms +13.14% -4.81% 16.34 ms +6.67% -2.82% 4.35%
typeContainer 8.86 ms +14.33% -2.48% 8.61 ms +11.38% -3.02% 2.9%
focus 71.03 ms +5.79% -5.36% 66.53 ms +19.92% -5.13% 6.76%
firstFocus 160.52 ms +0% -0% 151.35 ms +0% -0% 6.06%
selectAll 424.91 ms +0.65% -2.99% 416.99 ms +3.51% -1.37% 1.9%
listViewOpen 61.39 ms +20.85% -9.11% 58.27 ms +21.76% -7.55% 5.35%
inserterOpen 22.02 ms +4.77% -8.54% 21.19 ms +9.53% -5.95% 3.92%
inserterHover 3.78 ms +9.79% -17.72% 3.31 ms +14.8% -16.01% 14.2%
inserterSearch 8.16 ms +8.82% -7.35% 8.15 ms +4.17% -8.34% 0.12%
loadPatterns 599.43 ms +2.87% -2.22% 566.11 ms +1.25% -3.69% 5.89%
wpTotal 394.99 ms +2.6% -7.64% 390.99 ms +2.39% -5.43% 1.02%
wpMemoryUsage 13.05 MB +0% -0% 13.02 MB +0% -0% 0.28%
wpDbQueries 54 +0% -1.85% 54 +0% -0% 0%

site-editor

Metric 1d2dd1e trunk % Change
serverResponse 294.21 ms +1.66% -1.45% 279.9 ms +7.12% -4.81% 5.11%
firstPaint 272.04 ms +11.87% -41.25% 181.39 ms +8.81% -10.18% 49.98%
domContentLoaded 965.88 ms +2.97% -1.39% 965.14 ms +1.08% -0.84% 0.08%
loaded 966.79 ms +2.97% -1.39% 966.06 ms +1.07% -0.85% 0.08%
firstContentfulPaint 314.57 ms +6.86% -3.26% 311.2 ms +1.67% -1.05% 1.08%
firstBlock 3003.61 ms +0.88% -0.33% 3030.04 ms +0.42% -1.37% -0.87%
type 13.14 ms +2.51% -7.61% 12.78 ms +7.04% -5.01% 2.82%
navigate 73.96 ms +24.97% -16.01% 67.98 ms +24.37% -13.27% 8.8%
loadPatterns 1030.31 ms +9.41% -4.91% 1004.3 ms +17.03% -2.02% 2.59%
loadPages 1057.65 ms +9.83% -2.86% 1052.75 ms +6.97% -4.29% 0.47%
wpTotal 287.27 ms +1.35% -1.55% 272.9 ms +6.98% -5.12% 5.27%
wpMemoryUsage 12.06 MB +0% -0% 12.03 MB +0% -0% 0.3%
wpDbQueries 44 +0% -2.27% 44 +0% -2.27% 0%

13b35f6 Run

@manzoorwanijk manzoorwanijk added the [Type] Build Tooling Issues or PRs related to build tooling label Sep 9, 2026
@manzoorwanijk
manzoorwanijk marked this pull request as ready for review September 9, 2026 10:24
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: manzoorwanijk <manzoorwanijk@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

With setup-node in place the job can take the version from `.nvmrc`, leaving
the matrix to the operating systems. Node 26 coverage goes with it; the unit
tests and the `check` job still run it.
@manzoorwanijk

Copy link
Copy Markdown
Member Author

Closing in favor of #82662

@manzoorwanijk
manzoorwanijk deleted the ci/update-remaining-node-22-jobs branch September 9, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant