Skip to content

Pattern Translations: Restore cron job output under Cavalcade #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
obenland merged 1 commit into from
Oct 5, 2026
Merged

Pattern Translations: Restore cron job output under Cavalcade #785

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 24 additions & 26 deletions public_html/wp-content/plugins/pattern-translations/includes/cron.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,7 @@ function pattern_import_to_glotpress() {
$patterns = Pattern::get_patterns();
$makepot = new PatternMakepot( $patterns );
$result = $makepot->import( true );
if ( defined( 'WP_CLI' ) && WP_CLI ) {
WP_CLI::log( $result );
}
log_message( $result );
}
add_action( 'pattern_import_to_glotpress', __NAMESPACE__ . '\pattern_import_to_glotpress' );

Expand Down Expand Up @@ -70,9 +68,7 @@ function pattern_import_translations_to_directory( $pattern_ids = array() ) {
$timestamp += $delay;
}

if ( defined( 'WP_CLI' ) && WP_CLI ) {
WP_CLI::log( sprintf( 'Queued %d cron jobs of %d Patterns each.', count( $pattern_ids ) / CHUNK_SIZE, CHUNK_SIZE ) );
}
log_message( sprintf( 'Queued %d cron jobs of %d Patterns each.', count( $pattern_ids ) / CHUNK_SIZE, CHUNK_SIZE ) );
return;
}
}
Expand All @@ -92,21 +88,12 @@ function () {

$locales = get_locales();

if ( defined( 'WP_CLI' ) && WP_CLI ) {
WP_CLI::log( sprintf( 'Processing %d Patterns in %d locales.', count( $pattern_ids ), count( $locales ) ) );
}
log_message( sprintf( 'Processing %d Patterns in %d locales.', count( $pattern_ids ), count( $locales ) ) );

foreach ( $pattern_ids as $i => $pattern_id ) {
$pattern = Pattern::from_post( get_post( $pattern_id ) );

if ( wp_doing_cron() ) {
// phpcs:ignore WordPress.PHP.DevelopmentFunctions.error_log_error_log -- WP_CLI::log() output isn't captured by Cavalcade; this identifies the pattern if the job runs out of memory.
error_log( "Pattern translation import: processing {$pattern_id} ({$pattern->name})." );
}

if ( defined( 'WP_CLI' ) && WP_CLI ) {
WP_CLI::log( "{$i}. Processing {$pattern->name} / '{$pattern->title}'.." );
}
log_message( "{$i}. Processing {$pattern->name} / '{$pattern->title}'.." );
foreach ( $locales as $gp_locale ) {
$locale = $gp_locale->wp_locale;
if ( ! $locale || 'en_US' === $locale ) {
Expand All @@ -115,19 +102,15 @@ function () {

$translated = $pattern->to_locale( $locale );
if ( $translated ) {
if ( defined( 'WP_CLI' ) && WP_CLI ) {
WP_CLI::log( "\t{$locale} - " . ( $translated->ID ? 'Updating' : 'Creating' ) . ' Translated pattern.' );
}
log_message( "\t{$locale} - " . ( $translated->ID ? 'Updating' : 'Creating' ) . ' Translated pattern.' );
$result = create_or_update_translated_pattern( $translated );
if ( is_wp_error( $result ) ) {
// phpcs:ignore WordPress.PHP.DevelopmentFunctions.error_log_error_log -- cron output isn't reliably captured; the failure has to reach the server log.
// phpcs:ignore WordPress.PHP.DevelopmentFunctions.error_log_error_log -- failures need to reach the server log, not only the job output.
error_log( "Pattern translation import failed for {$pattern->name} ({$locale}): " . $result->get_error_message() );
if ( defined( 'WP_CLI' ) && WP_CLI ) {
WP_CLI::log( "\t{$locale} - ERROR: {$result->get_error_message()}" );
}
log_message( "\t{$locale} - ERROR: {$result->get_error_message()}" );
}
} elseif ( defined( 'WP_CLI' ) && WP_CLI ) {
WP_CLI::log( "\t{$locale} - No Translations exist yet." );
} else {
log_message( "\t{$locale} - No Translations exist yet." );

/*
* TODO: Note: There may exist a translated pattern using old strings.
Expand Down Expand Up @@ -156,3 +139,18 @@ function clear_memory_heavy_variables() {

wp_cache_flush_runtime();
}

/**
* Output a progress message.
*
* Cavalcade runs jobs without WP-CLI and records their output, so echo when WP-CLI isn't available.
*
* @param string $message The message to output.
*/
function log_message( $message ) {
if ( defined( 'WP_CLI' ) && WP_CLI ) {
WP_CLI::log( $message );
} else {
echo $message . "\n"; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped -- Plain-text job output.
}
}
Loading