Repository navigation
Conversation
…sion modal The inspector listed every category term, including retired ones, while the submission modal fetched without `per_page` and so only showed the first 10 terms. Both now read a single server-defined list of selectable category slugs, matching the categories registered by WordPress core. Also fixes layout issues in both category pickers: - Inspector: wrap the search field and list in a column Flex with a gap, as core does, so the list's negative top margin no longer overlaps the field. - Submission modal: list categories alphabetically down each column, and use a min-height for modal steps so the full list doesn't need a scrollbar. Fixes #611. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
annezazu
added
[Type] Bug
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (7)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthroughThe Pattern Directory now provides a curated list of selectable category slugs to the pattern creator. A shared hook filters category terms using that list, and both the inspector control and submission modal use the hook. ChangesPattern Category Selection
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix · Severity of issue fixed: Medium Sequence Diagram(s)sequenceDiagram
participant Pattern_Post_Type
participant wporgBlockPattern
participant usePatternCategories
participant PatternCategoriesControl
participant SubmissionModal
Pattern_Post_Type->>wporgBlockPattern: provide selectable category slugs
wporgBlockPattern->>usePatternCategories: supply configured slugs
usePatternCategories->>PatternCategoriesControl: return filtered category terms
usePatternCategories->>SubmissionModal: return filtered category terms
Suggested reviewers: Merge Risk: ⚪ Minimal · up to The inspector and submission modal now share one server-defined category list. The paging value used for the category request is handled by the plugin's existing request middleware, so both pickers receive their categories. No merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 6 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inspector listed every category term, including retired ones, while the submission modal fetched without
per_pageand so only showed the first 10 terms. Both now read a single server-defined list of selectable category slugs, matching the categories registered by WordPress core.I also made a few fixes to make this work:
Fixes #611.
Screenshots
Screen.Recording.2026-10-06.at.2.39.18.PM.mov
AI usage
I used Claude to help fix this and tested everything manually.
Summary by CodeRabbit