Repository navigation
Commands: Fix xray api bi balancer1 balancer2 - #7299
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #7279 and the request to include it in #7276. #7276 has since merged with the
adrulesfix; this is the remaining BI change on current main.The help documents
xray api bi balancer1 balancer2, but only the first tag is queried, including with--json. Query every supplied tag in order through the existing GetBalancerInfo RPC and output formatters. A failed later tag now reports an error instead of silently succeeding after querying only the first tag. JSON output is a sequence of complete response objects.The final merged diff contains the production fix. Two local regression cases called the actual command against a loopback gRPC recorder in text and JSON modes and verified both requested tags in order; both failed with the original source and passed with the fix. The fixture was removed during maintainer review. The merged production file is byte-identical to #7279.
Local validation against main
0afec660included the regression fixture:-race): all tests in./main/commands/... ./app/router/...pass (59 leaf tests on each platform; no test failures or skips).git diff --checkpass.go vet ./main/commands/... ./app/router/...reports the existing lost-cancel diagnostic atapp/router/command/command.go:101. It is identical with the original BI source and with the fix on Windows; Linux reports the same diagnostic. No analyzers were disabled.AI-assisted implementation and tests; separately reviewed and checked against the reproduced command behavior.