Repository navigation
fix: serialize order fee line tax as string - #812
Open
ArnoutPullen wants to merge 1 commit into
Open
ArnoutPullen wants to merge 1 commit into
ArnoutPullen wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The change is small, consistent with the library’s existing decimal-to-string serialization pattern, and directly addresses the documented WooCommerce API type requirement.
Pull request overview
This PR fixes WooCommerce order update requests failing due to fee_lines[].total_tax being serialized as a JSON number instead of the string type required by the WooCommerce REST API schema.
Changes:
- Adds a
total_taxValuebacking member (typed asobject) withDataMember(Name = "total_tax")to control JSON serialization shape. - Removes the
DataMemberattribute from thedecimal? total_taxproperty so the backing member is serialized instead (consistent with existingtotalhandling in the same class).
File summaries
| File | Description |
|---|---|
| WooCommerce/v2/Order.cs | Adjusts OrderFeeLine.total_tax serialization to emit a string value via the established *Value DataMember pattern, preventing WooCommerce “not of type string” validation errors. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes WooCommerce order updates failing when
fee_lines[].total_taxis serialized as a decimal instead of a string.WooCommerce Rest API Error:
{ "code": "rest_invalid_param", "message": "Invalid parameter(s): fee_lines", "data": { "status": 400, "params": { "fee_lines": "fee_lines[0][total_tax] is not of type string." }, "details": { "fee_lines": { "code": "rest_invalid_type", "message": "fee_lines[0][total_tax] is not of type string.", "data": { "param": "fee_lines[0][total_tax]" } } } } }See WooCommerce Rest Api Docs.