Repository navigation
Avoid copying large data - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set_data()takesimpl Into<Vec<u8>>, so aVec<u8>orStringgets moved ininstead of copied (slices, arrays and string literals still work).
Serializing writes in chunks instead of building the whole data URL in
memory first; Display uses that, and so does the new
write_to(), whichwrites to any
std::io::Write.encoded_len()gives the exact length ofthe serialized data URL without serializing it.
Parsing base64 decodes straight from the input when it has no "%" escapes,
and forgiving-base64 decoding no longer makes a stripped copy of its input.
For a 10 MB payload, peak memory while parsing went from about 40 MB to
10 MB (just the result), and parsing got about a third faster.
The CLI writes its output as it encodes it.