Propagate client-side cancellations to the caller - #641
Open
dzmitry-tsarevich wants to merge 1 commit into
Open
Conversation
Fixes logs spam due to OperationCancelledException writes, Fixes propagation of client-side cancellations in ex web API requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, thank you for great cache package.
Second, caching course is very nice!
We use your package in production environment a lot, and facing some problems with client-side cancellations.
When client cancels request, package spams
TaskCancelledExceptionto error log:What's bad is log also has exception stack trace so it reduces our servers performance for no reason.
Also as activity marked as error and
TaskCancelledExceptionexception is saved in, we have unneeded spam in traces.TaskCancelledExceptionwrites.TaskCancelledExceptions.