Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds six new mechanical prose-lint patterns (all model-free) and wires them into configuration and documentation, expanding the existing set of slop/pattern checks.
Changes:
- Added new pattern detectors and
Patterndefinitions for en-dash, middle dot, stock AI vocabulary, consecutive question chains, vague attribution, and count-first openings. - Added config flags (TOML + defaults + merge/apply) to enable/disable each new rule.
- Updated README example configuration to document the new pattern keys.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/patterns.rs | Implements six new detectors, registers them in active_patterns, and adds unit tests for the new detectors. |
| src/config.rs | Adds new pattern flags to the resolved config, TOML shadow types, defaults, and merge logic. |
| README.md | Documents the new [patterns] keys and brief descriptions in the sample config. |
Suppressed comments (1)
src/patterns.rs:819
- The new patterns add several config flags and
active_patternswiring, but the tests here only cover the individual detectors. Adding a unit test that verifies the new config flags actually disable the corresponding patterns would prevent regressions in theactive_patternswiring.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
en-dash: catches the Unicode dash in ranges such as10–20.ai-vocabulary: catches stock LLM words such asdelve,robust,leverage, andunlock.rhetorical-question-chain: catches two or more consecutive questions.vague-attribution: catches unsourced phrases such asexperts sayandstudies show.count-opening: catches openings such asthree thingsandtwo reasons.