Skip to content

added tree_with_loc and trees_with_loc - #71

Open
craff wants to merge 4 commits into
aantron:masterfrom
craff:tree_with_loc
Open

added tree_with_loc and trees_with_loc#71
craff wants to merge 4 commits into
aantron:masterfrom
craff:tree_with_loc

Conversation

@craff

@craff craff commented Jun 30, 2023

Copy link
Copy Markdown

Solves issue #70

@craff

craff commented Jun 30, 2023

Copy link
Copy Markdown
Author

I tried to fix/update the github workflow. I think it is now OK (not sure),
but there are some opam download that fails, even after I added opam update !

@craff craff mentioned this pull request Jul 4, 2023

@aantron aantron left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I have a few nits, all of which I can apply myself -- please let me know!

Comment thread src/markup.ml Outdated
Comment thread src/markup.mli
Comment thread src/utility.ml Outdated
Comment thread .github/workflows/test.yml Outdated
@craff

craff commented Jul 17, 2023

Copy link
Copy Markdown
Author

Am I supposed to do something for the coverage ?

@aantron

aantron commented Jul 17, 2023

Copy link
Copy Markdown
Owner

Am I supposed to do something for the coverage ?

Not necessary, unless you'd like to write some nice test cases!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants