Vendor mmkv_parser from abrignoni/mmkv-parser and guard it against drift - #1305
Merged
Conversation
scripts/mmkv_parser.py now carries a banner naming its upstream repository, file and commit (abrignoni/mmkv-parser at 526bc0f). The body below the banner is byte-identical to what was on main. admin/scripts/check_vendored.py reads that banner, fetches the upstream file at the pinned commit and fails when anything below the banner differs, so an edit made here is caught in CI instead of being reverted by the next re-vendor. It runs unconditionally in the lint workflow; a local checkout can be compared instead with --upstream. admin/test/scripts/test_check_vendored.py pins what counts as drift without touching the network. Proven locally: the check passes against GitHub and against a local checkout, exits 1 with a diff when one byte below the banner is changed, and passes again after the byte is restored. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vendors scripts/mmkv_parser.py from its new home, https://github.com/abrignoni/mmkv-parser, at commit 526bc0f. The body of the file is byte-identical to main; the only change is a banner naming the upstream repo, file and commit.
To change the reader, change it upstream, then copy the new file over the body and update the banner's commit line.
🤖 Generated with Claude Code