Phase 1: repo scaffold, Postgres smoke tests, Bun + Node CI - #2
Merged
Conversation
Stand up the package, specHelper, and Postgres smoke tests. CI runs the same node:test files on Bun and Node 26 against a Postgres service. There is no docker-compose file; local tests only need DATABASE_URL. Bun uses --max-concurrency=1; Node uses --test-concurrency=1. Co-authored-by: Evan Tahler <evan@evantahler.com>
Set noImplicitAny in tsconfig, typecheck tests via tsconfig.test.json, and fail lint on explicit any. Co-authored-by: Evan Tahler <evan@evantahler.com>
Restore bun:test for Postgres tests and add scripts/assert-node-package.mjs so CI proves Node 26 can import dist without duplicating the suite. Co-authored-by: Evan Tahler <evan@evantahler.com>
The node-package job already sets up Node 26; invoke the smoke script with that binary so the check cannot run under Bun. Co-authored-by: Evan Tahler <evan@evantahler.com>
evantahler
marked this pull request as ready for review
August 26, 2026 05:34
Keep the flag explicit in tsconfig.json (not only implied by strict) and repeat it on tsconfig.test.json so tests stay covered if strict is relaxed. Co-authored-by: Evan Tahler <evan@evantahler.com>
The GitHub token for this agent cannot write branch protection or rulesets (403). Co-authored-by: Evan Tahler <evan@evantahler.com>
The agent token cannot write branch protection or rulesets. Co-authored-by: Evan Tahler <evan@evantahler.com>
Acceptance criteria are met on this PR; squash-merge is the remaining step. Co-authored-by: Evan Tahler <evan@evantahler.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements docs/plans/01-repo-scaffold.md.
What this ships
pgboss-queue0.0.1, Bun, Biome, TypeScript, emptysrc/index.ts)specHelper+bun:testsmoke tests that runSELECT 1against Postgresnode scripts/assert-node-package.mjsimports the compiledexports["."].importentry (dist/index.js) and asserts it is running on Node, not Bun.github/workflows/test.yaml: lint, build, Bun Postgres tests,node-package(invokesnodedirectly, notbun run),completeRuntime
engines.node>=26,.nvmrc)--max-concurrency=1(notbun test --concurrency=1)No
anytsconfig.jsonandtsconfig.test.jsonsetnoImplicitAny(not only implied bystrict)bun run buildtypechecks tests viatsconfig.test.jsonsuspicious/noExplicitAnyis an errorLocal Postgres
No
docker-compose.yml. SetDATABASE_URL(see.env.example). CI starts Postgres as a GitHub Actions service.Plan updates
Phase 1 status is
in-progressuntil merge. Lessons learned and related notes are in phases 1, 7, 8, and 10.