Skip to content

Add exempt-issue-types option for blocklist filter by issue type#1294

Open
veryfancy wants to merge 2 commits into
actions:mainfrom
veryfancy:exempt-issue-types
Open

Add exempt-issue-types option for blocklist filter by issue type#1294
veryfancy wants to merge 2 commits into
actions:mainfrom
veryfancy:exempt-issue-types

Conversation

@veryfancy

@veryfancy veryfancy commented Oct 3, 2025

Copy link
Copy Markdown

Description:

Introduce a parameter exempt-issue-types that ensures that issues from a list of types will not be marked stale or closed.

This is a blocklist counterpart to the allowlist option only-issue-types added in:

Related issue:

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@veryfancy veryfancy requested a review from a team as a code owner October 3, 2025 21:52
Copilot AI review requested due to automatic review settings October 3, 2025 21:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@maxwxyz

maxwxyz commented Oct 4, 2025

Copy link
Copy Markdown

@luketomlinson this is similar to #1255

@Bibo-Joshi Bibo-Joshi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. As a heads-up, I see that main.ts was not updated, which will probably lead to the input being ignored. See #1298, were I discovered that for only-issue-types :)

@veryfancy veryfancy requested a review from Bibo-Joshi October 15, 2025 22:12
@veryfancy

Copy link
Copy Markdown
Author

@Bibo-Joshi Thank you for the heads-up. I updated main.ts to include input reading for exemptIssueTypes. I included onlyIssueTypes as well, in case this merges first (and because I suspect it might prevent a merge conflict if your PR merges first).

@Bibo-Joshi Bibo-Joshi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet :)

@moritzheiber

Copy link
Copy Markdown

@veryfancy heads-up, #1298 was just merged, so this will need conflict resolution

@veryfancy

Copy link
Copy Markdown
Author

Resolved conflicts. 🚀

@veryfancy

Copy link
Copy Markdown
Author

Bump to this. 🙏

1 similar comment
@veryfancy

Copy link
Copy Markdown
Author

Bump to this. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants